build: add missing comma in node.gyp#31959
Merged
Merged
Conversation
nodejs-github-bot
added
the
build
gengjiawen
approved these changes
Feb 26, 2020
addaleax
approved these changes
Feb 26, 2020
richardlau
approved these changes
Feb 26, 2020
bnoordhuis
approved these changes
Feb 26, 2020
bnoordhuis
left a comment
bnoordhuis
left a comment
Member
There was a problem hiding this comment.
Not just consistency. GYP works like python in that it concatenates strings unless separated by a comma.
lpinca
approved these changes
Feb 26, 2020
Collaborator
Collaborator
ChALkeR
approved these changes
Feb 27, 2020
cjihrig
added
the
author ready
Member
|
Can we fast track this ? Code navigation not working due to this. Found MSVS version 15.0
configure --dest-cpu=x64
Node.js configure: Found Python 2.7.17...
Warning: Missing input files:
src\large_pages\node_large_page.hsrc\memory_tracker.h
tools\msvs\genfiles\node_etw_provider.rc
tools\msvs\genfiles\node_etw_provider.h |
Contributor
Author
|
This has the approvals, CI run, etc. Please 👍 this comment to approve fast tracking as @gengjiawen requests. |
This commit adds a missing comma for consistency with the surrounding lines. PR-URL: nodejs#31959 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Feb 27, 2020
This commit adds a missing comma for consistency with the surrounding lines. PR-URL: #31959 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Merged
Member
|
Depends on the large pages change to land on v12.x |
targos
removed
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
This commit adds a missing comma for consistency with the surrounding lines. PR-URL: nodejs#31959 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
This commit adds a missing comma for consistency with the surrounding lines. PR-URL: #31959 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a missing comma for consistency with the surrounding lines.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes